Allow controller SA to describe Secrets - fixes cross account dynamic provisioning #1256
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @RyanStan. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/L
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
RyanStan
force-pushed
the
cross-account-mount-fixes
branch
from
4e121a2
to
43d8f3c
Compare
For cross account provisioning, the controller pods need to be able to describe the x-account K8s Secret in the kube-system namespace. Additionally, I modified the IAM Role used in our cross-account mount example. Users should use the managed AmazonEFSCSIDriverPolicy, which I've copied here. Eventually, we will update the documentation to reference the managed policy instead of this file.
RyanStan
force-pushed
the
cross-account-mount-fixes
branch
from
43d8f3c
to
cc355e1
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mskanth972, RyanStan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
For cross account provisioning, the controller pods need to be able to describe K8s Secrets in the kube-system namespace.
Additionally, I modified the IAM Role used in our cross-account mount example. Users should use the managed AmazonEFSCSIDriverPolicy, which I've copied into describe-mount-target-example.json to be compatible with existing documentation links. Eventually, we will update the documentation to point at the managed policy instead of this file.
Why did I change that IAM Policy?
The describe-mount-target IAM Role wasn't working when following this blog post:
https://aws.amazon.com/blogs/storage/mount-amazon-efs-file-systems-cross-account-from-amazon-eks/
That's because it was missing two key permissions:
elasticfilesystem:TagResourceandelasticfilesystem:DescribeAccessPointsTesting:
I performed a Helm installation and a kustomize installation of the driver. For each, I then performed a cross-account mount and ensured it was successful.